Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDA 12.4 to supported PTX versions #15247

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add CUDA 12.4 to supported PTX versions #15247

merged 1 commit into from
Mar 7, 2024

Conversation

brandon-b-miller
Copy link
Contributor

This PR updates the mapping from PTX version to toolkit versions to cover CUDA 12.4.

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner March 7, 2024 18:01
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 7, 2024
@bdice
Copy link
Contributor

bdice commented Mar 7, 2024

I wonder if there is a way for us to detect the user's compiler and get the mapping of "8.4" to (12, 4) directly, and then insert it into the dict. That would allow us to support arbitrary versions found on the user system, I think.

cc: @gmarkall if you have thoughts on this.

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 7, 2024
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 188d7cb into rapidsai:branch-24.04 Mar 7, 2024
73 checks passed
@bdice bdice mentioned this pull request Jun 6, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandon-b-miller @bdice @jakirkham