Improve performance in JSON reader when mixed_types_as_string option is enabled
#15236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrshi
added
libcudf
|
Benchmarks were run on A100 80GB GPU, with all combinations of
|
|
The entire 30x slowdown was in the type inference? |
|
Yes, the slowdown seems to be due to long string sizes when mixed types is enabled. If we enforce the column to be a string in the JSON tree parser, we can skip the type inference kernel. |
|
/ok to test |
karthikeyann
approved these changes
Mar 6, 2024
vuule
approved these changes
Mar 6, 2024
GregoryKimball
changed the title
mixed_types_as_string option is enabledmixed_types_as_string option is enabled
|
/ok to test |
karthikeyann
reviewed
Mar 8, 2024
|
/ok to test |
|
/merge |
This was referenced Mar 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #15196 by applying a patch from @karthikeyann to skip the
infer_column_type_kernelby forcing the mixed types column to be a string.With this optimization, we see a significant improvement in performance. Please refer to the comment for a visualization of the results before and after applying this optimization as obtained from the JSON lines benchmarking exercise.
Checklist