Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset value for generating test data in parquet_chunked_reader_test.cu #15200

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Fix offset value for generating test data in parquet_chunked_reader_test.cu #15200

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c374df1
Fix offset for nulls
ttnghia Mar 1, 2024
2e05765
Merge branch 'branch-24.04' into fix_parquet_chunk_reader_test
ttnghia Mar 5, 2024
99e9ada
Merge branch 'branch-24.04' into fix_parquet_chunk_reader_test
karthikeyann Mar 6, 2024
f47184c
Merge branch 'branch-24.04' into fix_parquet_chunk_reader_test
ttnghia Mar 6, 2024
b78e6e9
Merge branch 'branch-24.04' into fix_parquet_chunk_reader_test
ttnghia Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp/tests/io/parquet_chunked_reader_test.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ auto write_file(std::vector<std::unique_ptr<cudf::column>>& input_columns,
std::size_t max_page_size_bytes = cudf::io::default_max_page_size_bytes,
std::size_t max_page_size_rows = cudf::io::default_max_page_size_rows)
{
// Just shift nulls of the next column by one position to avoid having all nulls in the same
// table rows.
if (nullable) {
// Generate deterministic bitmask instead of random bitmask for easy computation of data size.
auto const valid_iter = cudf::detail::make_counting_transform_iterator(
Expand All @@ -83,6 +81,10 @@ auto write_file(std::vector<std::unique_ptr<cudf::column>>& input_columns,
std::move(col),
cudf::get_default_stream(),
rmm::mr::get_current_device_resource());

// Shift nulls of the next column by one position, to avoid having all nulls
// in the same table rows.
++offset;
}
}

Expand Down Expand Up @@ -988,7 +990,7 @@ TEST_F(ParquetChunkedReaderTest, TestChunkedReadWithListsOfStructs)

{
auto const [result, num_chunks] = chunked_read(filepath_with_nulls, 1'500'000);
EXPECT_EQ(num_chunks, 4);
EXPECT_EQ(num_chunks, 5);
CUDF_TEST_EXPECT_TABLES_EQUAL(*expected_with_nulls, *result);
}

Expand Down
Loading