Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change strings_column_view::char_size to return int64 #15197

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Change strings_column_view::char_size to return int64 #15197

merged 2 commits into from
Mar 5, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Changes the cudf::strings_column_view::chars_size() function to return int64_t instead of size_type

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 29, 2024
@davidwendt davidwendt self-assigned this Feb 29, 2024
@davidwendt davidwendt added breaking Breaking change 3 - Ready for Review Ready for review by team and removed non-breaking Non-breaking change 2 - In Progress Currently a work in progress labels Feb 29, 2024
@davidwendt davidwendt marked this pull request as ready for review March 1, 2024 14:27
@davidwendt davidwendt requested a review from a team as a code owner March 1, 2024 14:27
@davidwendt davidwendt requested review from harrism and ttnghia March 1, 2024 14:27
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8d073e4 into rapidsai:branch-24.04 Mar 5, 2024
76 checks passed
@davidwendt davidwendt deleted the chars-size-int64 branch March 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@harrism harrism harrism approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @harrism @ttnghia