Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includes for row_operators.cuh #15194

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Simple change removes the cudf/sorting.hpp include from row_operators.cuh.
Found this while waiting for recompiles to finish.
Changes to sorting.hpp seemed to cause more recompiling than expected.
Also took the opportunity to change the include <limits> to include <cuda/limits>

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 29, 2024
@davidwendt davidwendt self-assigned this Feb 29, 2024
@vyasr vyasr mentioned this pull request Mar 1, 2024
3 tasks
@davidwendt davidwendt marked this pull request as ready for review March 1, 2024 14:28
@davidwendt davidwendt requested a review from a team as a code owner March 1, 2024 14:28
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d3e49f6 into rapidsai:branch-24.04 Mar 1, 2024
76 checks passed
@davidwendt davidwendt deleted the fix-rowop-includes branch March 1, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants