Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dict normalization in __dask_tokenize__ #15187

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Avoid dict normalization in __dask_tokenize__ #15187

merged 1 commit into from
Feb 29, 2024

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented Feb 29, 2024 •
edited
Loading

Description

There are currently CI failures that seem to be caused by non-deterministic dict normalization in Frame.__dask_tokenize__. This PR avoids normalizing that dictionary.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora requested a review from a team as a code owner February 29, 2024 03:03
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 29, 2024
@rjzamora rjzamora added bug Something isn't working 0 - Waiting on Author Waiting for author to respond to review non-breaking Non-breaking change labels Feb 29, 2024
@vyasr
Copy link
Contributor

vyasr commented Feb 29, 2024

/merge

@rapids-bot rapids-bot bot merged commit b670af6 into rapidsai:branch-24.04 Feb 29, 2024
76 checks passed
@rjzamora rjzamora deleted the dont-normalize-dict branch February 29, 2024 14:02
@bdice bdice mentioned this pull request Feb 29, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
0 - Waiting on Author Waiting for author to respond to review bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjzamora @vyasr @bdice