Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override to_pandas for Datelike columns #15167

Merged
merged 8 commits into from
Mar 7, 2024

Conversation

mroeschke
Copy link
Contributor

Description

pandas.Series(pyarrow.array) is first interpreted as an object data type since pandas doesn't know how to handle pyarrow arrays yet which is bad. Additionally if pyarrow becomes required in pandas this may have different behavior in the future.

I think the linked issues might be outdated and we can rely on pyarrow's to_pandas

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 28, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 28, 2024 02:08
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c2bb860 into rapidsai:branch-24.04 Mar 7, 2024
74 checks passed
@mroeschke mroeschke deleted the ref/to_pandas3 branch March 7, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants