Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded script parameters in test_cpp_memcheck.sh #15158

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Remove unneeded script parameters in test_cpp_memcheck.sh #15158

merged 5 commits into from
Feb 29, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Fixes error introduced in #14992 in test_cpp_memcheck.sh
Extra line of parameters removed from the call to run_cudf_memcheck_ctests.sh

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Feb 27, 2024
@davidwendt davidwendt self-assigned this Feb 27, 2024
@github-actions github-actions bot added the ci label Feb 27, 2024
@davidwendt davidwendt marked this pull request as ready for review February 27, 2024 18:54
@davidwendt davidwendt requested a review from a team as a code owner February 27, 2024 18:54
vyasr
vyasr requested changes Feb 27, 2024
View reviewed changes
ci/test_cpp_memcheck.sh Outdated Show resolved Hide resolved
@davidwendt davidwendt requested a review from vyasr February 27, 2024 20:07
@jakirkham
Copy link
Member

/merge

(adding this proactively so it gets merged once CI passes)

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 15f11e1 into rapidsai:branch-24.04 Feb 29, 2024
77 checks passed
@davidwendt davidwendt deleted the bug-memcheck-test branch February 29, 2024 15:10
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @jakirkham @vyasr @raydouglass @bdice