Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HostColumnVector.DataType accessor methods public #15157

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Make HostColumnVector.DataType accessor methods public #15157

merged 6 commits into from
Feb 28, 2024

Conversation

jbrennan333
Copy link
Contributor

Description

As part of work on host memory oom handling in the spark-rapids plugin, I am copying (maybe moving) some ColumnBuilder code from HostColumnVector.java into the plugin. The following subclasses are referenced by ColumnBuilder: DataType, ListType, StructData, StructType, and BasicType. These are public static inner classes, but the accessor methods are protected and cannot be accessed from the spark-rapids plugin. This patch just makes the accessor methods of these classes public.

Checklist

  • [x ] I am familiar with the Contributing Guidelines.
  • [na] New or existing tests cover these changes.
  • [na] The documentation is up to date with these changes.

@jbrennan333 jbrennan333 added Java Affects Java cuDF API. improvement Improvement / enhancement to an existing function labels Feb 27, 2024
@jbrennan333 jbrennan333 self-assigned this Feb 27, 2024
@jbrennan333 jbrennan333 requested a review from a team as a code owner February 27, 2024 18:07
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 27, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jbrennan333 jbrennan333 added Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Feb 27, 2024
@jbrennan333
Copy link
Contributor Author

/ok to test

@jbrennan333
Copy link
Contributor Author

/ok to test

@jbrennan333
Copy link
Contributor Author

/merge

@jbrennan333
Copy link
Contributor Author

/ok to test

@jbrennan333
Copy link
Contributor Author

/ok to test

@jbrennan333
Copy link
Contributor Author

/merge

@AyodeAwe AyodeAwe merged commit 3adfddc into rapidsai:branch-24.04 Feb 28, 2024
71 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@jlowe jlowe jlowe approved these changes

Assignees

@jbrennan333 jbrennan333

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrennan333 @jlowe @revans2 @AyodeAwe