Java: Add leak tracking for Scalar instances #15121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
jlowe
added
Java
ttnghia
approved these changes
Feb 22, 2024
Good question. I suspect it was skipped back when we weren't sure how much overhead this was going to add (we are creating more objects to do this tracking, adding to GC overhead), and scalars back then were guaranteed to be tiny (no list/struct scalar support in the old days) so not as worried about leaking. However scalars, even though they're tiny, are really good at fragmenting GPU memory when they're leaked. |
gerashegalov
approved these changes
Feb 22, 2024
revans2
approved these changes
Feb 23, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Scalar as another Closeable instance that can be tracked via the leak tracking framework in the cudf Java bindings.
Checklist