Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arrow large_string in cudf #15093

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Add support for arrow large_string in cudf #15093

merged 5 commits into from
Feb 20, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

This PR adds support for large_string type of arrow arrays in cudf. cudf strings column lacks 64 bit offset support and it is WIP: #13733

This workaround is essential because pandas-2.2+ is now defaulting to large_string type for arrow-strings instead of string type.: pandas-dev/pandas#56220

This PR fixes all 25 dask-cudf failures.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Feb 20, 2024
@galipremsagar galipremsagar self-assigned this Feb 20, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner February 20, 2024 18:08
@galipremsagar galipremsagar requested a review from vyasr February 20, 2024 18:08
@galipremsagar galipremsagar added the bug Something isn't working label Feb 20, 2024
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Feb 20, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6903f80 into rapidsai:branch-24.04 Feb 20, 2024
68 checks passed
@GregoryKimball GregoryKimball mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@shwina shwina shwina approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @shwina @mroeschke