Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove offsets_begin() call from nvtext::generate_ngrams #15077

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Remove offsets_begin() call from nvtext::generate_ngrams #15077

merged 3 commits into from
Feb 27, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Removes call to strings_column_view::offsets_begin() call from nvtext::generate_ngrams().
A future PR will deprecate the offsets_begin() function which hardcodes to int32 type.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 16, 2024
@davidwendt davidwendt self-assigned this Feb 16, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 21, 2024
@davidwendt davidwendt marked this pull request as ready for review February 21, 2024 15:14
@davidwendt davidwendt requested a review from a team as a code owner February 21, 2024 15:14
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c32725d into rapidsai:branch-24.04 Feb 27, 2024
68 checks passed
@davidwendt davidwendt deleted the ngrams-remove-offsets-begin branch February 27, 2024 20:40
@GregoryKimball GregoryKimball mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @hyperbolic2346 @bdice