Extend cudf devcontainers to specify jitify2 kernel cache #15068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that inside devcontainers, the helper clean commands will also remvoe the jitify2 cache as it is part of the build directory.
robertmaynard
added
feature request
|
We'll also need this change in the unified devcontainers (i.e. in https://github.com/rapidsai/devcontainers). |
The unified devcontainers have the change ( https://github.com/rapidsai/devcontainers/blob/branch-24.04/.devcontainer/rapids.Dockerfile#L53 ) |
|
Ah didn't see that got lumped into the CUDA 12.2 PR. All good then. |
|
/merge |
trxcllnt
reviewed
Mar 11, 2024
Co-authored-by: Paul Taylor <[email protected]>
|
/merge |
vyasr
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures that inside devcontainers, the helper clean commands will also remvoe the jitify2 cache as it is part of the build directory.
Checklist