Fix is_device_write_preferred
in void_sink
and user_sink_wrapper
#15064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses a few issues in
data_sink
classes to avoid D2H copies in writers when using avoid_sink
.Provide an
is_device_write_preferred
implementation to always prefer device writes.Implement
is_device_write_preferred
inuser_sink_wrapper
that forwards the call to the wrapped object.Use the
cudf::io::void_sink
in benchmarks instead of the local version, which is not fully implemented.Checklist