Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_device_write_preferred in void_sink and user_sink_wrapper #15064

Merged

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Feb 15, 2024

Description

Addresses a few issues in data_sink classes to avoid D2H copies in writers when using a void_sink.
Provide an is_device_write_preferred implementation to always prefer device writes.
Implement is_device_write_preferred in user_sink_wrapper that forwards the call to the wrapped object.
Use the cudf::io::void_sink in benchmarks instead of the local version, which is not fully implemented.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working tests Unit testing for project cuIO cuIO issue Performance Performance related issue non-breaking Non-breaking change labels Feb 15, 2024
@vuule vuule self-assigned this Feb 15, 2024
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 15, 2024
@vuule
Copy link
Contributor Author

vuule commented Feb 15, 2024

This should speed up some of the writer benchmarks significantly (~2X), but does not improve throughput in any real use case.
The only possible impact might come from fixed is_device_write_preferred in user_sink_wrapper, but we don't cover user implemented sinks in libcudf benchmarks.

@vuule vuule marked this pull request as ready for review February 15, 2024 22:28
@vuule vuule requested a review from a team as a code owner February 15, 2024 22:28
@vuule vuule requested review from harrism and ttnghia February 15, 2024 22:28
@ttnghia
Copy link
Contributor

ttnghia commented Feb 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 634b4cb into rapidsai:branch-24.04 Feb 20, 2024
69 checks passed
@vuule vuule deleted the bug-void-sink-prefer-device-write branch February 20, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants