Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_resample index dtype checking for pandas 2.2 #15058

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

mroeschke
Copy link
Contributor

Description

I think this got unintentionally fixed in pandas 2.2, but pandas.testing.assert_series_equal will be strict about checking a Series's Index's dtype for date-likes. Since pandas always returns ns in resample and cudf tries to match the resolution frequency (IMO the better behavior), need to specify check_index=False in pandas 2.2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 14, 2024 22:58
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 093fe6a into rapidsai:branch-24.04 Feb 20, 2024
68 checks passed
@mroeschke mroeschke deleted the p22/test_resample branch February 20, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants