Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting a clean build directory also clears Jitify cache #15052

Conversation

robertmaynard
Copy link
Contributor

Description

Developers expect that 'cleaning' a build directory will remove all forms of cached files ( objects, libraries, jit cache, etc ). To ensure that happens consistenly we also need to remove the jitify cache objects for cudf.

Checklist

@robertmaynard robertmaynard added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Feb 14, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner February 14, 2024 16:35
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Feb 14, 2024
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Hopefully this saves other people a day. 😁

@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 825d30c into rapidsai:branch-24.04 Feb 14, 2024
68 checks passed
@robertmaynard robertmaynard deleted the bug/remove_jitify2_cache_on_clean branch February 14, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants