Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid incompatible value type setting in test_rolling for pandas 2.2 #15050

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Avoid incompatible value type setting in test_rolling for pandas 2.2 #15050

merged 2 commits into from
Feb 15, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Related to https://pandas.pydata.org/pdeps/0006-ban-upcasting.html

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 14, 2024 00:15
@mroeschke mroeschke requested review from shwina and bdice February 14, 2024 00:15
@bdice bdice changed the title Avoid incompatabile value type setting in test_rolling for pandas 2.2 Avoid incompatible value type setting in test_rolling for pandas 2.2 Feb 14, 2024
@mroeschke
Copy link
Contributor Author

/merge

1 similar comment
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0f694d3 into rapidsai:branch-24.04 Feb 15, 2024
69 checks passed
@mroeschke mroeschke deleted the p22/test_rolling branch February 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @bdice @galipremsagar