Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chained replace inplace test to COW test for pandas 2.2 #15049

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

mroeschke
Copy link
Contributor

Description

test_setitem_dataframe_series_inplace failed with pandas 2.2 because it exhibits a chained indexing behavior that raised a FutureWarning in pandas 2.2 and will raise in 3.0. I refactored the test to test cudf copy on write to exhibit the 3.0 behavior, but it still seems to allow this chained indexing behavior, so xfailed it for now.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 14, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 14, 2024 00:06
@mroeschke mroeschke requested review from wence- and vyasr February 14, 2024 00:06
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 4ca9ac8 into rapidsai:branch-24.04 Feb 20, 2024
68 checks passed
@mroeschke mroeschke deleted the p22/test_setitem branch February 20, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants