Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid chained indexing in test_indexing for pandas 2.2 #15045

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Avoid chained indexing in test_indexing for pandas 2.2 #15045

merged 2 commits into from
Feb 15, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Feb 13, 2024 •
edited
Loading

Description

Chained indexing raises a FutureWarning in pandas 2.2. Since this test doesn't look to specifically test that, refactoring the test to avoid that

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 13, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 13, 2024 22:57
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3dbdb14 into rapidsai:branch-24.04 Feb 15, 2024
69 checks passed
@mroeschke mroeschke deleted the p22/test_indexing branch February 15, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar