Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tests in test_dataframe.py for pandas 2.2 #15023

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Adjust tests in test_dataframe.py for pandas 2.2 #15023

merged 5 commits into from
Feb 15, 2024

Conversation

mroeschke
Copy link
Contributor

Description

  • Removed an unnecessary replace that causes a deprecated down casting test_all
  • Updated the tests cases in test_update_for_dataframes to do replacement with equivalent types as an update that upcasts/downcasts is deprecated in pandas 2.2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 9, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 9, 2024 23:00
@mroeschke mroeschke requested review from wence- and shwina February 9, 2024 23:00
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e57afdd into rapidsai:branch-24.04 Feb 15, 2024
68 checks passed
@mroeschke mroeschke deleted the p22/test_dataframe branch February 15, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar