Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate casting strings to datetime in isin #15022

Closed
wants to merge 5 commits into from
Closed

Deprecate casting strings to datetime in isin #15022

wants to merge 5 commits into from

Conversation

galipremsagar
Copy link
Contributor

Description

This PR deprecates casting strings to datetime-like types. This deprecation was introduced in pandas-2.2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 9, 2024
@galipremsagar galipremsagar self-assigned this Feb 9, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner February 9, 2024 22:34
@galipremsagar galipremsagar requested a review from vyasr February 9, 2024 22:34
@galipremsagar
Copy link
Contributor Author

Closing this PR as it is addressed in #15046

@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke Awaiting requested review from mroeschke

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @vyasr