Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Index.difference to handle duplicate values when one of the inputs is empty #15016

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Fix Index.difference to handle duplicate values when one of the inputs is empty #15016

merged 2 commits into from
Feb 10, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

This PR removes duplicate values in two short-circuit code-paths of Index.difference which is already fixed in pandas-2.2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Feb 9, 2024
@galipremsagar galipremsagar self-assigned this Feb 9, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner February 9, 2024 18:36
@galipremsagar galipremsagar requested a review from isVoid February 9, 2024 18:36
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8edbeca into rapidsai:branch-24.04 Feb 10, 2024
68 checks passed
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @mroeschke @vyasr