Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up detail sequence header inclusion #15007

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Clean up detail sequence header inclusion #15007

merged 1 commit into from
Feb 8, 2024

Conversation

PointKernel
Copy link
Member

Description

A small fix avoiding the detail sequence header including itself.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added libcudf Affects libcudf (C++/CUDA) code. tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 8, 2024
@PointKernel PointKernel requested a review from a team as a code owner February 8, 2024 02:34
@PointKernel PointKernel added the 3 - Ready for Review Ready for review by team label Feb 8, 2024
@bdice
Copy link
Contributor

bdice commented Feb 8, 2024

🤯

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 8503b31 into rapidsai:branch-24.04 Feb 8, 2024
69 checks passed
@PointKernel PointKernel deleted the fix-sequence-include branch February 9, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @bdice @davidwendt