Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use offsetalator in cudf::row_bit_count() #15003

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Use offsetalator in cudf::row_bit_count() #15003

merged 5 commits into from
Feb 21, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates cudf::row_bit_count() to use the offsetalator to compute chars size for a strings column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 8, 2024
@davidwendt davidwendt self-assigned this Feb 8, 2024
@davidwendt davidwendt marked this pull request as ready for review February 13, 2024 20:46
@davidwendt davidwendt requested a review from a team as a code owner February 13, 2024 20:46
ttnghia
ttnghia approved these changes Feb 21, 2024
View reviewed changes
cpp/src/transform/row_bit_count.cu Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 14b149a into rapidsai:branch-24.04 Feb 21, 2024
68 checks passed
@davidwendt davidwendt deleted the bit-count-offsetalator branch February 21, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @ttnghia