Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use offsetalator in cudf::strings::wrap() #15002

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Use offsetalator in cudf::strings::wrap() #15002

merged 1 commit into from
Feb 12, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates cudf::strings::wrap() to use the offsetalator instead of hardcoded int32 type for offsets column data.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2024
@davidwendt davidwendt self-assigned this Feb 7, 2024
@davidwendt davidwendt marked this pull request as ready for review February 8, 2024 15:17
@davidwendt davidwendt requested a review from a team as a code owner February 8, 2024 15:17
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit daa63d2 into rapidsai:branch-24.04 Feb 12, 2024
69 checks passed
@davidwendt davidwendt deleted the wrap-offsetalator branch February 12, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @karthikeyann @ttnghia