Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded calls to create_chars_child_column utility #14997

Merged
merged 14 commits into from
Feb 16, 2024
Merged

Remove unneeded calls to create_chars_child_column utility #14997

merged 14 commits into from
Feb 16, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Removes unneeded calls to cudf::strings::detail::create_chars_child_column.
This includes all calls except make_strings_children which will be modified in a follow-on PR.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2024
@davidwendt davidwendt self-assigned this Feb 7, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Feb 12, 2024
@davidwendt davidwendt marked this pull request as ready for review February 14, 2024 20:02
@davidwendt davidwendt requested a review from a team as a code owner February 14, 2024 20:02
PointKernel
PointKernel approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 45614e2 into rapidsai:branch-24.04 Feb 16, 2024
69 checks passed
@davidwendt davidwendt deleted the rem-chars-child-calls-pt1 branch February 16, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

@shrshi shrshi Awaiting requested review from shrshi shrshi is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @PointKernel