Filter all DeprecationWarning's by ArrowTable.to_pandas()
#14989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
mroeschke
reviewed
Feb 7, 2024
| pytestmark = pytest.mark.filterwarnings( | ||
| "ignore", | ||
| category=DeprecationWarning, | ||
| message="Passing a BlockManager to DataFrame is deprecated", |
There was a problem hiding this comment.
cudf never deals with the pandas block manager right? If not, I would just globally ignore this in python/cudf/cudf/tests/pytest.ini with ignore:Passing a BlockManager to DataFrame is deprecated:DeprecationWarning
There was a problem hiding this comment.
We don't deal with it, it shows up every time when we do:
arrow_table = pa.table(...)
arrow_table.to_pandas()
There was a problem hiding this comment.
Done, moved the filter to pytest.ini
galipremsagar
commented
Feb 7, 2024
python/cudf/cudf/tests/test_avro_reader_fastavro_integration.py
Outdated
Show resolved
Hide resolved
python/cudf/cudf/tests/test_avro_reader_fastavro_integration.py
Outdated
Show resolved
Hide resolved
galipremsagar
commented
Feb 7, 2024
mroeschke
approved these changes
Feb 7, 2024
galipremsagar
added
5 - Ready to Merge
|
/merge |
mroeschke
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR filters all
DeprecationWarning's that are being originated byArrowTable.to_pandasChecklist