Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate certain frequency strings #14967

Merged
merged 9 commits into from
Feb 6, 2024
Merged

Deprecate certain frequency strings #14967

merged 9 commits into from
Feb 6, 2024

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Feb 5, 2024 •
edited
Loading

Description

This PR deprecates "H", "N", "T", "L", "U" and "S" as frequencies in all datetime APIs. This PR prepares branch-24.04 for pandas-2.2 support.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 5, 2024
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 5, 2024
@galipremsagar galipremsagar changed the title Handle deprecated freq strings Deprecate certain frequency strings Feb 6, 2024
@galipremsagar galipremsagar self-assigned this Feb 6, 2024
@galipremsagar galipremsagar marked this pull request as ready for review February 6, 2024 00:05
@galipremsagar galipremsagar requested a review from a team as a code owner February 6, 2024 00:05
mroeschke
mroeschke reviewed Feb 6, 2024
View reviewed changes
python/cudf/cudf/_lib/datetime.pyx Outdated
if freq == "D":
freq_val = libcudf_datetime.rounding_frequency.DAY
elif freq == "H":
elif freq in ("H", "h"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do freq = old_to_new_freq_map.get(freq, freq) and then update these elif checks with the future frequency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, updated the code 👍

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit cf32049 into rapidsai:branch-24.04 Feb 6, 2024
68 checks passed
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @mroeschke @vyasr