Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect IntervalDtype and CategoricalDtype objects passed by users #14961

Merged
merged 16 commits into from
Mar 8, 2024
Merged

Respect IntervalDtype and CategoricalDtype objects passed by users #14961

merged 16 commits into from
Mar 8, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Broken off of #14636, these cases are strict about a dtype being set so no need to be in a try except

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 3, 2024
@mroeschke mroeschke requested a review from a team as a code owner February 3, 2024 01:37
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 3, 2024
@mroeschke mroeschke removed the improvement Improvement / enhancement to an existing function label Feb 3, 2024
@mroeschke mroeschke changed the title Repect IntervalDtype and CategoricalDtype objects passed by users Respect IntervalDtype and CategoricalDtype objects passed by users Feb 6, 2024
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 6c18729 into rapidsai:branch-24.04 Mar 8, 2024
74 checks passed
@mroeschke mroeschke deleted the ref/as_column/misc_pt1 branch March 8, 2024 17:38
@mroeschke mroeschke mentioned this pull request Mar 8, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @wence-