Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite cudf internals using pylibcudf groupby #14946

Merged
merged 13 commits into from
Feb 5, 2024
Merged

Rewrite cudf internals using pylibcudf groupby #14946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
84eb201
Plug in pylibcudf's groupby aggregation object
vyasr Jan 30, 2024
738dcdb
Switch to using pylibcudf for scans
vyasr Jan 30, 2024
67dda3b
Consolidate helper functions
vyasr Jan 31, 2024
ce2250a
Switch actual aggregation implementation to use pylibcudf
vyasr Jan 31, 2024
bc74242
Switch over scans
vyasr Jan 31, 2024
7d2329a
Use pylibcudf for replace_nulls
vyasr Jan 31, 2024
13a849c
Use pylibcudf for groups
vyasr Jan 31, 2024
21176f2
Remove now unnecessary C objects from Cython GroupBy
vyasr Jan 31, 2024
97cb7a5
Simplify old logic
vyasr Jan 31, 2024
645d59a
Remove now outdated comment
vyasr Jan 31, 2024
5c12d23
Release the GIL in pylibcudf functions
vyasr Feb 2, 2024
1ea0a8d
Add missing linking in pylibcudf docs
vyasr Feb 2, 2024
049787f
Merge branch 'branch-24.04' into feat/use_pylibcudf_groupby
vyasr Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions python/cudf/cudf/_lib/aggregation.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Copyright (c) 2020-2022, NVIDIA CORPORATION.
# Copyright (c) 2020-2024, NVIDIA CORPORATION.

from libcpp.memory cimport unique_ptr

from cudf._lib cimport pylibcudf
from cudf._lib.cpp.aggregation cimport (
groupby_aggregation,
groupby_scan_aggregation,
Expand All @@ -15,10 +16,7 @@ cdef class RollingAggregation:
cdef unique_ptr[rolling_aggregation] c_obj

cdef class GroupbyAggregation:
cdef unique_ptr[groupby_aggregation] c_obj

cdef class GroupbyScanAggregation:
cdef unique_ptr[groupby_scan_aggregation] c_obj
cdef pylibcudf.aggregation.Aggregation c_obj

cdef class ReduceAggregation:
cdef unique_ptr[reduce_aggregation] c_obj
Expand All @@ -28,6 +26,5 @@ cdef class ScanAggregation:

cdef RollingAggregation make_rolling_aggregation(op, kwargs=*)
cdef GroupbyAggregation make_groupby_aggregation(op, kwargs=*)
cdef GroupbyScanAggregation make_groupby_scan_aggregation(op, kwargs=*)
cdef ReduceAggregation make_reduce_aggregation(op, kwargs=*)
cdef ScanAggregation make_scan_aggregation(op, kwargs=*)
Loading
Loading