Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace legacy cudf and dask_cudf imports as (d)gd #14944

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Replace legacy cudf and dask_cudf imports as (d)gd #14944

merged 2 commits into from
Feb 1, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Discussed offline, replacing this legacy import style without aliasing

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 1, 2024
@mroeschke mroeschke requested review from a team as code owners February 1, 2024 00:25
rjzamora
rjzamora approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I was actually making a lot of these same changes in #14805

@bdice
Copy link
Contributor

bdice commented Feb 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 6b3462b into rapidsai:branch-24.04 Feb 1, 2024
68 checks passed
@mroeschke mroeschke deleted the cln/old_import branch February 1, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mroeschke @bdice @rjzamora @galipremsagar