Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace _is_datetime64tz/interval_dtype with isinstance #14943

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Replace _is_datetime64tz/interval_dtype with isinstance #14943

merged 6 commits into from
Feb 5, 2024

Conversation

mroeschke
Copy link
Contributor

Description

This is more explicit than the methods which may allow array objects where we don't want to

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2024
@mroeschke mroeschke requested review from a team as code owners January 31, 2024 22:54
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 9e9f2b9 into rapidsai:branch-24.04 Feb 5, 2024
68 checks passed
@mroeschke mroeschke deleted the cln/_is_datetime64tz_dtype branch February 5, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @galipremsagar @bdice