Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for pandas 2. #14941

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Update tests for pandas 2. #14941

merged 1 commit into from
Feb 1, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 31, 2024

Description

A few cleanups in test files following #14916.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 31, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2024
@bdice bdice self-assigned this Jan 31, 2024
@bdice bdice marked this pull request as ready for review February 1, 2024 19:55
@bdice bdice requested review from a team as code owners February 1, 2024 19:55
@bdice bdice requested review from galipremsagar and isVoid February 1, 2024 19:55
@galipremsagar
Copy link
Contributor

/merge

charlesbluca
charlesbluca approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice!

Noticed while grepping through for other pandas 1.x compat I noticed there's still some places in docs that could be updated:

https://github.com/bdice/cudf/blob/da1fb0215d930dcb7b2bbb86a0307eb2bcac29e2/docs/cudf/source/cudf_pandas/faq.md#L139

Don't think that needs to be handled here, but might be worth an additional comb through the docs mentions of pandas

@bdice
Copy link
Contributor Author

bdice commented Feb 1, 2024

@charlesbluca I think I handled those in #14940! If you see any more, please let me know or file a PR.

@charlesbluca
Copy link
Member

Ah my bad! Totally missed that this branch is a little outdated 😅 thanks!

@rapids-bot rapids-bot bot merged commit 2b0d987 into rapidsai:branch-24.04 Feb 1, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @galipremsagar @charlesbluca