Fix Null literals to be not parsed as string when mixed types as string is enabled in JSON reader #14939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeyann
added
bug
karthikeyann
added
3 - Ready for Review
mythrocks
approved these changes
Feb 1, 2024
This was referenced Feb 7, 2024
shrshi
reviewed
Feb 12, 2024
| test_fn(R"( | ||
| { "a": { "b": 1 } } |
There was a problem hiding this comment.
Can you help me understand why we have STRUCT + STR when we already have STR + STRUCT test case in line 2112? This also applies for the other <STRUCT, STR, LIST> permutations above. Does the ordering of the records in the JSON lines input matter for the parser?
There was a problem hiding this comment.
One of the examples provided by @andygrove successfully caught a segfault bug where the ordering is different. After fixing the bug, for unit tests, I created all test cases with different order.
andygrove
approved these changes
Feb 21, 2024
shrshi
approved these changes
Feb 23, 2024
vyasr
added
4 - Needs Review
nvdbaranec
reviewed
Feb 27, 2024
nvdbaranec
reviewed
Feb 27, 2024
nvdbaranec
approved these changes
Mar 6, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
Addresses part of #14288 Depends on #14939 (mixed type ignore nulls fix) In the input schema, if a struct column is given as STRING type, it's forced to be a STRING column. This could be used to support map type in spark JSON reader. (Force a map type to be a STRING, and use different parser to extract this string column as key, value columns) To enable this forcing, mixed type as string should be enabled in json_reader_options. Authors: - Karthikeyan (https://github.com/karthikeyann) - Nghia Truong (https://github.com/ttnghia) Approvers: - Andy Grove (https://github.com/andygrove) - Mike Wilson (https://github.com/hyperbolic2346) - Shruti Shivakumar (https://github.com/shrshi) - Bradley Dice (https://github.com/bdice) URL: #14936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14864
nullliteral should be ignored (considered as null) during parsing while handling mixed types.Unit tests of complex scenarios are added to test this as well.
Checklist