-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue with output chunking computation stemming from input chunking. #14889
Merged
rapids-bot
merged 2 commits into
rapidsai:branch-24.02
from
nvdbaranec:output_chunk_indexing_fix
Jan 25, 2024
Merged
Fixed an issue with output chunking computation stemming from input chunking. #14889
rapids-bot
merged 2 commits into
rapidsai:branch-24.02
from
nvdbaranec:output_chunk_indexing_fix
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumns resulting from input pass splitting would result in incorrect indexing when computing output chunking.
nvdbaranec
added
bug
Something isn't working
libcudf
Affects libcudf (C++/CUDA) code.
cuIO
cuIO issue
5 - DO NOT MERGE
Hold off on merging; see PR for details
non-breaking
Non-breaking change
labels
Jan 25, 2024
3 tasks
Leaving the do-not-merge label on so I can soak this through the spark integration tests. |
nvdbaranec
requested review from
vuule,
ttnghia and
davidwendt
and removed request for
hyperbolic2346 and
shrshi
January 25, 2024 20:23
ttnghia
approved these changes
Jan 25, 2024
hyperbolic2346
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit and a const comment
vuule
approved these changes
Jan 25, 2024
Spark integration tests passed. |
/merge |
hyperbolic2346
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
cuIO
cuIO issue
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14883
The core issue was that the output chunking code was expecting all columns to have terminating pages that end in the same row count. Previously this was the case because we always processed entire row groups. But now with the subrowgroup reader, we can split on page boundaries that cause a jagged max row index for different columns. Example:
The input chunking would have computed a max row index of 200 for the subpass. But when computing the output chunks, there was code that would have tried finding where row 300 was in column A, resulting in an out-of-bounds read.
The fix is simply to cap the max row seen for column B to be the max expected row for the subpass.
Checklist