Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-DOS line-endings #14880

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jan 25, 2024

Description

These are the only two files in the repo (other than the sphinx make.bat files, which should have DOS line-endings) that use \r\n as the line-ending. Let's fix that.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

These are the only two files in the repo (other than the sphinx
make.bat files, which should have DOS line-endings) that use \r\n as
the line-ending. Let's fix that.
@wence- wence- requested a review from a team as a code owner January 25, 2024 11:35
@wence- wence- requested review from ttnghia and PointKernel January 25, 2024 11:35
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 25, 2024
@wence- wence- added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 25, 2024
@wence-
Copy link
Contributor Author

wence- commented Jan 25, 2024

(Best reviewed with "hide whitespace" selected).

After merge, the merge commit can be added to .git-blame-ignore-revs if we want.

@davidwendt
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 35011dd into rapidsai:branch-24.04 Jan 25, 2024
67 of 68 checks passed
@wence- wence- deleted the wence/fix/de-dos branch January 26, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants