Add detail cuco_allocator
#14877
Merged
Add detail cuco_allocator
#14877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
3 - Ready for Review
ttnghia
reviewed
Jan 25, 2024
PointKernel
force-pushed
the
add-cuco-allocator
branch
from
35428d2 to
f9ce36f
Compare
ttnghia
reviewed
Jan 26, 2024
ttnghia
reviewed
Jan 26, 2024
ttnghia
reviewed
Jan 26, 2024
ttnghia
approved these changes
Jan 26, 2024
vyasr
approved these changes
Jan 29, 2024
| @@ -117,7 +117,7 @@ template <typename Key, | |||
| typename Element, | |||
| typename Hasher = cudf::hashing::detail::default_hash<Key>, | |||
| typename Equality = equal_to<Key>, | |||
| typename Allocator = default_allocator<thrust::pair<Key, Element>>> | |||
| typename Allocator = rmm::mr::polymorphic_allocator<thrust::pair<Key, Element>>> | |||
There was a problem hiding this comment.
I guess this can't use the cuco_allocator because it needs to allocate in units that aren't just raw bytes, but instead based on the Key/Element pair size?
There was a problem hiding this comment.
Exactly, cuco uses a trait internally to convert the given allocator to the desired type thus the input data type doesn't really matter. concurrent_unordered_map doesn't have this implemented thus we have to pass the proper type to make it work.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Surpass #14827
Related to #11176
This PR adds a new
cudf::detail::cuco_allocatorto deprecate and replace the olddefault_allocatorin the global namespace. Following the comments in #14827 (review), the newcudf::detail::cuco_allocatorclass is moved todetail/cuco_helpers.cuh. Free functions inhashing/detail/helper_functions.cuhare left in the global namespace without changes due to the verbose nested namespace expression.Checklist