Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all core types to using enum class in Cython #14876

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Move all core types to using enum class in Cython #14876

merged 3 commits into from
Jan 25, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 25, 2024

Description

This change is a necessary prerequisite for adding other APIs to pylibcudf that need these types.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 25, 2024
@vyasr vyasr self-assigned this Jan 25, 2024
@vyasr vyasr requested a review from a team as a code owner January 25, 2024 01:59
@vyasr vyasr requested review from shwina and galipremsagar January 25, 2024 01:59
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 25, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Jan 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit f14ba22 into rapidsai:branch-24.04 Jan 25, 2024
69 checks passed
@vyasr vyasr deleted the feat/types_enum_class branch January 25, 2024 15:48
@vyasr vyasr added the pylibcudf Issues specific to the pylibcudf package label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @bdice