Update cudf for compatibility with the latest cuco #14849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
3 - Ready for Review
davidwendt
reviewed
Jan 23, 2024
This was referenced Jan 23, 2024
PointKernel
force-pushed
the
fix-cuco-conflicts
branch
from
757d225 to
2db13a0
Compare
PointKernel
commented
Jan 29, 2024
davidwendt
reviewed
Jan 29, 2024
davidwendt
approved these changes
Jan 29, 2024
vyasr
approved these changes
Jan 29, 2024
PointKernel
changed the title
PointKernel
added
5 - Ready to Merge
karthikeyann
approved these changes
Feb 12, 2024
rapids-bot bot
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Feb 15, 2024
This PR bumps to the latest cuco version which removes experimental namespace and includes multiple bug fixes. CI must pass on these PRs before we can merge this change: - [ ] rapidsai/cudf#14849 - [ ] rapidsai/cugraph#4111 - [ ] rapidsai/raft#2118 Authors: - Yunsong Wang (https://github.com/PointKernel) - Robert Maynard (https://github.com/robertmaynard) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: #526
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Depends on #14849 Contributes to #12261 This PR migrates hash groupby to use the new `cuco::static_set` data structure. It doesn't change any existing libcudf behavior but uncovers the fact that the cudf python `value_counts` doesn't guarantee output orders thus the PR becomes a breaking change. Authors: - Yunsong Wang (https://github.com/PointKernel) Approvers: - David Wendt (https://github.com/davidwendt) - Vyas Ramasubramani (https://github.com/vyasr) URL: #14813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on rapidsai/rapids-cmake#526
CMakes changes will be reverted once rapidsai/rapids-cmake#526 is merged.
This PR updates libcudf to make it compatible with the latest cuco.
Checklist