-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI workflows for pandas-tests and add test summary. #14847
Changes from 24 commits
c6c2b78
b9ef194
2c576bf
de86653
b78c27c
67b1430
4d3afba
c00b271
c743838
79baa49
cb09742
9567fed
a5c7eb1
7075302
3d5260f
5088481
b8fba57
67a303c
7b3b361
9c6810e
fe0b29a
16ac70f
c8f0290
f6688f9
d71a0de
7f12d1a
fa7b996
f062e28
47fb2f0
9b3c322
264b3cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,12 +16,13 @@ | |
# | ||
# This script creates a `pandas-testing` directory if it doesn't exist | ||
|
||
set -euo pipefail | ||
|
||
# Grab the Pandas source corresponding to the version | ||
# of Pandas installed. | ||
PANDAS_VERSION=$(python -c "import pandas; print(pandas.__version__)") | ||
|
||
PYTEST_IGNORES="--ignore=tests/io/test_user_agent.py" | ||
PYTEST_IGNORES="--ignore=tests/io/test_user_agent.py --ignore=tests/interchange/test_impl.py" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we just inline this variable? It's only used once, it's defined far from that location (the pytest call), and it's incongruous with how we provide basically every other argument inline. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's "far" in lines of code but not really that far semantically. It's just that there's another very large variable definition in between. I think I'm going to leave this as-is because I don't think it is worth another CI run to change. |
||
|
||
mkdir -p pandas-testing | ||
cd pandas-testing | ||
|
@@ -92,7 +93,7 @@ cd pandas-tests/ | |
# test_overwrite_warns unsafely patchs over Series.mean affecting other tests when run in parallel | ||
# test_complex_series_frame_alignment randomly selects a DataFrames and axis to test but particular random selection(s) always fails | ||
# test_numpy_ufuncs_basic compares floating point values to unbounded precision, sometimes leading to failures | ||
TEST_NUMPY_UFUNCS_BASIC_FLAKY="test_numpy_ufuncs_basic[float-exp] \ | ||
TEST_NUMPY_UFUNCS_BASIC_FLAKY="not test_numpy_ufuncs_basic[float-exp] \ | ||
and not test_numpy_ufuncs_basic[float-exp2] \ | ||
and not test_numpy_ufuncs_basic[float-expm1] \ | ||
and not test_numpy_ufuncs_basic[float-log] \ | ||
|
@@ -183,11 +184,10 @@ and not test_numpy_ufuncs_basic[nullable_float-rad2deg]" | |
|
||
PANDAS_CI="1" python -m pytest -p cudf.pandas \ | ||
-m "not single_cpu and not db" \ | ||
-k "not test_overwrite_warns and not test_complex_series_frame_alignment and not $TEST_NUMPY_UFUNCS_BASIC_FLAKY" \ | ||
--durations=50 \ | ||
--import-mode=importlib \ | ||
bdice marked this conversation as resolved.
Show resolved
Hide resolved
|
||
-k "not test_overwrite_warns and not test_complex_series_frame_alignment and $TEST_NUMPY_UFUNCS_BASIC_FLAKY" \ | ||
-o xfail_strict=True \ | ||
${PYTEST_IGNORES} $@ | ||
${PYTEST_IGNORES} \ | ||
"$@" | ||
|
||
mv *.json .. | ||
cd .. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you choose to use
--numprocesses
instead of-n
to match the conda tests? I'm fine with either option but I think (without having done any real investigation) that-n
is more common. That may also be a dichotomy between wheels/conda (since we implemented GHA for each in parallel at roughly the same time there was less coordination/enforcement of uniformity) that we could try to unify over time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've generally chosen to write the full names of flags wherever possible in our CI scripts. You're correct, this was an artifact of us doing isolated work on conda and wheels at the same time. I took this opportunity to make them match.