Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI workflows for pandas-tests and add test summary. #14847
Fix CI workflows for pandas-tests and add test summary. #14847
Changes from 28 commits
c6c2b78
b9ef194
2c576bf
de86653
b78c27c
67b1430
4d3afba
c00b271
c743838
79baa49
cb09742
9567fed
a5c7eb1
7075302
3d5260f
5088481
b8fba57
67a303c
7b3b361
9c6810e
fe0b29a
16ac70f
c8f0290
f6688f9
d71a0de
7f12d1a
fa7b996
f062e28
47fb2f0
9b3c322
264b3cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you choose to use
--numprocesses
instead of-n
to match the conda tests? I'm fine with either option but I think (without having done any real investigation) that-n
is more common. That may also be a dichotomy between wheels/conda (since we implemented GHA for each in parallel at roughly the same time there was less coordination/enforcement of uniformity) that we could try to unify over time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've generally chosen to write the full names of flags wherever possible in our CI scripts. You're correct, this was an artifact of us doing isolated work on conda and wheels at the same time. I took this opportunity to make them match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just inline this variable? It's only used once, it's defined far from that location (the pytest call), and it's incongruous with how we provide basically every other argument inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's "far" in lines of code but not really that far semantically. It's just that there's another very large variable definition in between. I think I'm going to leave this as-is because I don't think it is worth another CI run to change.