Fix V2 Parquet page alignment for use with zStandard compression #14841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrshi
added
improvement
|
/ok to test |
hyperbolic2346
approved these changes
Jan 25, 2024
|
/ok to test |
vuule
reviewed
Jan 25, 2024
| uncompressed_size += hdr_len; | ||
| data_len = page_g.max_data_size; | ||
| data_len = ck_g.is_compressed ? page_g.comp_data_size : page_g.data_size; | ||
| // Copy page data. For V2, the level data and page data are disjoint. |
There was a problem hiding this comment.
disjoint because of the alignment padding?
There was a problem hiding this comment.
Yes. I suppose there will be cases where they are actually contiguous, but I don't know how worth it it is to test for that.
vuule
approved these changes
Jan 25, 2024
|
/ok to test |
|
trying to check if the bot works with the command at the end of the comment |
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14781
This PR makes changes to the Parquet writer to ensure that data to be compressed is properly aligned. Changes have also been made to the
EncPagestruct to make it easier to keep fields in that struct aligned, and also to reduce confusing re-use of fields. In particular, themax_data_sizefield can be any of a) the maximum possible size for the page data, b) the actual size of page data after encoding, c) the actual size of compressed page data. The latter two now have their own fields,data_sizeandcomp_data_size.Checklist