Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch 24.04 merge branch 24.02 #14806

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Branch 24.04 merge branch 24.02 #14806

merged 3 commits into from
Jan 19, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 19, 2024

Description

Replaces #14803

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

ZelboK and others added 3 commits January 19, 2024 18:45
@ZelboK
Expose streams in public filling APIs for label_bins (rapidsai#14401)
9bb9af6 
Contributes to rapidsai#925. Introduces cuda_stream parameter for downstream users to provide for `labeling_bins`

Authors:
  - Danial Javady (https://github.com/ZelboK)
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#14401
@davidwendt
Move cudf::char_utf8 definition from detail to public header (rapidsa…
446da75 
…i#14779)

Moves the `cudf::char_utf8` definition from the `cudf/strings/detail/utf8.hpp` to `cudf/types.hpp` since it is declared in the public namespace and used in public functions.

Reference: https://github.com/rapidsai/cudf/blob/9acddc08cc209e8d6b94891be6131edd63ff5b43/docs/cudf/source/conf.py#L372-L375

Authors:
  - David Wendt (https://github.com/davidwendt)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Yunsong Wang (https://github.com/PointKernel)
  - Nghia Truong (https://github.com/ttnghia)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#14779
@vyasr
Merge branch 'branch-24.02' into branch-24.04-merge-branch-24.02
e8d187d
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 19, 2024
@vyasr vyasr self-assigned this Jan 19, 2024
@vyasr vyasr requested a review from a team as a code owner January 19, 2024 19:35
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jan 19, 2024
@raydouglass raydouglass merged commit 8dd6c7a into rapidsai:branch-24.04 Jan 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdbaranec nvdbaranec nvdbaranec approved these changes

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @nvdbaranec @raydouglass @ZelboK @davidwendt