Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shared-workflows repo name #14784

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Fix shared-workflows repo name #14784

merged 4 commits into from
Jan 19, 2024

Conversation

raydouglass
Copy link
Member

Description

Fix the repo name for shared-workflows

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change labels Jan 18, 2024
@raydouglass raydouglass requested a review from a team as a code owner January 18, 2024 19:55
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also remove -DNVBench_ENABLE_CUPTI=OFF from the devcontainer job while we're here? That is no longer needed. Otherwise we can file a separate PR for that, but it feels like a small enough change to wrap into another PR and conserve CI resources.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took care of removing the cupti flag.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (branch-24.02@d017cf4). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-24.02   #14784   +/-   ##
===============================================
  Coverage                ?   86.05%           
===============================================
  Files                   ?      175           
  Lines                   ?    27441           
  Branches                ?        0           
===============================================
  Hits                    ?    23614           
  Misses                  ?     3827           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdice
Copy link
Contributor

bdice commented Jan 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit a38fc01 into branch-24.02 Jan 19, 2024
67 checks passed
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 20, 2024
Fix the repo name for `shared-workflows`

See: rapidsai/cudf#14784

Authors:
  - Ray Douglass (https://github.com/raydouglass)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #5723
@raydouglass raydouglass deleted the raydouglass-patch-1 branch January 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants