Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up DatetimeIndex.__init__ constructor #14774

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Clean up DatetimeIndex.__init__ constructor #14774

merged 3 commits into from
Jan 19, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Jan 17, 2024 •
edited
Loading

Description

Additionally adds some typing and remove validation done by cudf.dtype and add a unit test to ensure numpy dtype objects are accepted in the constructor

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Jan 17, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 17, 2024 22:45
@mroeschke mroeschke requested review from wence- and vyasr January 17, 2024 22:45
@mroeschke mroeschke changed the title Allow DatetimeIndex to accept a numpy dtype Clean up DatetimeIndex.__init__ constructor Jan 17, 2024
@mroeschke mroeschke mentioned this pull request Jan 17, 2024
Merged
3 tasks
@mroeschke mroeschke added improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels Jan 17, 2024
@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2c1b949 into rapidsai:branch-24.02 Jan 19, 2024
68 checks passed
rapids-bot bot pushed a commit that referenced this pull request Jan 19, 2024
@mroeschke
Clean up TimedeltaIndex.__init__ constructor (#14775)
d017cf4 
Aligns the constructor closer to `DatetimeIndex.__init__`: #14774

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #14775
@mroeschke mroeschke deleted the ref/dti/init branch January 19, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr