Simplify ColumnAccessor methods; avoid unnecessary validations #14758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
vyasr
requested changes
Jan 18, 2024
vyasr
reviewed
Jan 19, 2024
vyasr
approved these changes
Jan 23, 2024
|
/merge |
PointKernel
pushed a commit
to PointKernel/cudf
that referenced
this pull request
Jan 25, 2024
…sai#14758) For methods that essentially do ```python def select_by_foo(self, ...): ... return self.__class__(data={subset of self._data}) ``` The `return` would perform validation on the returned subset of column, but I think that's unnecessary since that was done during initialization Additionally * Removed `_create_unsafe` in favor of a `verify=True|False` keyword in the constructor * `_column_length` == `nrows` so removed `_column_length` * Renamed `_compare_keys` to `_keys_equal` * Remove seldom used/unnecessary methods Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: rapidsai#14758
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 13, 2024
#14758 may have propagated a caching invalidation bug of the number of rows in a `ColumnAccessor` Previously the number of rows was cached and cleared only if an operation caused the `ColumnAccessor` to have no more columns. However, if the `ColumnAccessor` was empty and operation added new columns, the cached number of rows should have also been cleared. Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #15710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For methods that essentially do
The
returnwould perform validation on the returned subset of column, but I think that's unnecessary since that was done during initializationAdditionally
_create_unsafein favor of averify=True|Falsekeyword in the constructor_column_length==nrowsso removed_column_length_compare_keysto_keys_equalChecklist