Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate cudf object handling in as_column #14754

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Consolidate cudf object handling in as_column #14754

merged 5 commits into from
Jan 19, 2024

Conversation

mroeschke
Copy link
Contributor

Description

Since these paths are very similar, consolidating these paths and returning early for this case

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 12, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 12, 2024 18:37
vyasr
vyasr approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions, but nothing blocking. Would wait for @shwina's feedback on the nan_as_null question.

python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 09b6e45 into rapidsai:branch-24.02 Jan 19, 2024
67 checks passed
@mroeschke mroeschke deleted the ref/as_column/cudf_objs branch January 19, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina left review comments

@vyasr vyasr vyasr approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @vyasr @shwina