Reduce execution time of Parquet C++ tests #14750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
tests
bdice
approved these changes
Jan 11, 2024
|
CC @nvdbaranec @etseidl who wrote or modified many of these tests. |
etseidl
reviewed
Jan 12, 2024
karthikeyann
approved these changes
Jan 12, 2024
…impr-reduce-pq-cpp-tests
shrshi
reviewed
Jan 16, 2024
| @@ -688,60 +687,9 @@ TEST_P(ParquetV2Test, PartitionedWriteEmptyColumns) | |||
| CUDF_TEST_EXPECT_TABLES_EQUAL(expected2, result2.tbl->view()); | |||
| } | |||
|
|
|||
| TEST_P(ParquetV2Test, LargeColumnIndex) | |||
There was a problem hiding this comment.
Can you help me understand why this test has been removed?
There was a problem hiding this comment.
That's a great question, I should have left a comment before reviews.
This test was included only to test the case where the writer writes the data in two batches (not the same as chunks!). Batching has since been disabled so we don't need this (huge) test.
hyperbolic2346
approved these changes
Jan 16, 2024
Co-authored-by: Nghia Truong <[email protected]>
ttnghia
approved these changes
Jan 16, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduced time from 90s to 25s on local system. Very few tests are impacted, and there should be no impact on code coverage.
Checklist