Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use get_offset_value utility in strings shift function #14743

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Use get_offset_value utility in strings shift function #14743

merged 7 commits into from
Jan 23, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Updates cudf::strings::detail::shift to support int32 or int64 offset types by changing calls to get_value to get_offset_value.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2024
@davidwendt davidwendt self-assigned this Jan 11, 2024
@davidwendt davidwendt changed the base branch from branch-24.02 to branch-24.04 January 22, 2024 14:08
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 22, 2024
@davidwendt davidwendt marked this pull request as ready for review January 22, 2024 14:21
@davidwendt davidwendt requested a review from a team as a code owner January 22, 2024 14:21
PointKernel
PointKernel approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bc706af into rapidsai:branch-24.04 Jan 23, 2024
66 of 67 checks passed
@davidwendt davidwendt deleted the shift-offsetalator branch January 23, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @ttnghia @PointKernel