Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic bug introduced in #14730 #14742

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix logic bug introduced in #14730 #14742

merged 1 commit into from
Jan 12, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jan 11, 2024

Description

The removal of valid_count on columns in #14730 had one logic bug, fixed here.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner January 11, 2024 15:17
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jan 11, 2024
@wence- wence- added bug Something isn't working non-breaking Non-breaking change labels Jan 11, 2024
mroeschke
mroeschke approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

vyasr
vyasr approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I totally missed the not while reading.

@mroeschke
Copy link
Contributor

/merge

1 similar comment
@wence-
Copy link
Contributor Author

wence- commented Jan 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit 5c78b7e into rapidsai:branch-24.02 Jan 12, 2024
68 checks passed
@wence- wence- deleted the wence/fix/valid-count-removal branch January 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@vyasr vyasr vyasr approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wence- @mroeschke @vyasr